8000 Add more detail to code execution documentation by maeste · Pull Request #983 · huggingface/smolagents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add more detail to code execution documentation #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

maeste
Copy link
Contributor
@maeste maeste commented Mar 14, 2025

Fixes #919


For instance, if you have allowed an innocuous package like `Pillow` to process images, the LLM could generate thousands of image saves to bloat your hard drive.
Other examples of attacks can be found [here](https://gynvael.coldwind.pl/n/python_sandbox_escape).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this line? I think it had nice examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, for sure, it's a nice example, and I'm ok with keeping it. I removed it just because, in my own experience, referencing an external website (and a very dynamic one in this case) is a bit risky because it could disappear, and you don't realize it until someone complains about it. It's even worse if the examples contained become less relevant or not aligned with your doc. But again, I'm OK with keeping it if you prefer.

8000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Let's go with this removal.

@aymeric-roucher
Copy link
Collaborator

Thank you @maeste , great insights! Just one comment above, but it's open to discussion !

@aymeric-roucher aymeric-roucher merged commit 1957144 into huggingface:main Apr 11, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more detail to code execution documentation
3 participants
0