Fix Tool.to_dict for nullable input parameter #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI error is unrelated: |
src/smolagents/tools.py
Outdated
| @@ -222,7 +222,7 @@ def to_dict(self) -> dict: | |||
| class {class_name}(Tool): | |||
| name = "{self.name}" | |||
| description = {json.dumps(textwrap.dedent(self.description).strip())} | |||
| inputs = {json.dumps(self.inputs, separators=(",", ":"))} | |||
| inputs = {self.inputs} | |||
There was a problem hiding this comment.
What prompted me to use this json.dumps was that only using fstring here meant that some dicts would be converted to strings poorly, this fixed it. Also this new version may show dict keys with simple quotes, is this intended?
There was a problem hiding this comment.
In Python, there is no difference between using single (') or double (") quotes for strings: they are interchangeable.
Regarding the formatting, instead of using an f-string, I could use the repr function. This ensures that the dictionary representation remains evaluable/executable while preserving its structure more reliably.
aymeric-roucher
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Tool.to_dictfor nullable input parameter.Currently, nullable parameters are exported to dict with
nullablevalue astrue, which is not valid Python syntax.