8000 Improve ApiModel and subclasses instantiation by albertvillanova · Pull Request #1095 · huggingface/smolagents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve ApiModel and subclasses instantiation #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 31, 2025
Merged

Improve ApiModel and subclasses instantiation #1095

merged 10 commits into from
Mar 31, 2025

Conversation

albertvillanova
Copy link
Member
@albertvillanova albertvillanova commented Mar 28, 2025 •
edited
Loading

Improve ApiModel and subclasses instantiation:

  • commmon params are set in the parent class
  • client is created by calling create_client

@albertvillanova albertvillanova changed the title Improve ApiModel Improve ApiModel and subclasses instantiation Mar 28, 2025
@albertvillanova albertvillanova marked this pull request as ready for review March 28, 2025 15:39
@albertvillanova albertvillanova merged commit 6a3ccbc into huggingface:main Mar 31, 2025
3 checks passed
@albertvillanova albertvillanova mentioned this pull request Mar 31, 2025
Closed
@albertvillanova albertvillanova deleted the improve-api-model branch April 8, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvillanova @aymeric-roucher
0