Add support for virtualenv #1119
Conversation
Add a `gef.virtualenv_path` config var, and activate it at startup.
There was a problem hiding this comment.
TL;DR: I think this needs to be re-worked at least by adding way more test cases and documentation.
As I mentioned, a lot of complications come when dealing with seperate environments, and so it should be tested way more, for instance:
- we need to check the venv is running at least for the minimum Python version we supported
- what happens when a user uses a python version different from that with gdb
- what happens when a user switches between venv
- etc.
In addition, this should be exhaustively documented - not just the gef config option, but how to use gef in a virtual env because it is 100% certain users will come with such questions (and/or bad issue reports about it)
The pyenv was done hastily which came to bite us down the line, let's not repeat that mistake
| @@ -9943,6 +9946,13 @@ def load_plugins_from_directory(plugin_directory: pathlib.Path): | |||
| dbg(f"Loading extra plugins from directory={directory}") | |||
| return load_plugins_from_directory(directory) | |||
|
|
|||
|
|
|||
| def load_virtualenv(self, new_path: Optional[pathlib.Path] = None): | |||
There was a problem hiding this comment.
Not sure if this makes sense as a method here
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue. |
|
Assigning to shush state-bot |
|
@ValekoZ Update on this PR? |
|
I'll work on it later, I don't have much time these days (but it should get better in the coming weeks :D) |
No problem at all 😄 |
Add a
gef.virtualenv_pathconfig var, and activate the provided virtualenv at startup.This could be used by gef-extras to install python dependencies cleanly.