8000 Setup fallback 'debug-file-directory' by tesuji · Pull Request #1173 · hugsy/gef · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Setup fallback 'debug-file-directory' #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

Setup fallback 'debug-file-directory' #1173

merged 2 commits into from
Feb 13, 2025

Conversation

tesuji
Copy link
Contributor
@tesuji tesuji commented Feb 12, 2025 •
edited by Grazfather
Loading

Description

This PR adds fallback path /usr/lib/debug to debug-file-directory config.
Closes #1169.

Some gdbs installed outside /usr (like nix or in user homedir) will not search
for dbgsyms in /usr/lib/debug. However /us/lib/debug is where most distros
package debuginfo symbols to.

Before

> /run/workspace/bin/gdb -q -x .gef.py -ex 'show debug-file-directory' -ex 'quit'
The directory where separate debug symbols are searched for is "/nix/store/k51rfv38p65jbhw906vpl85yg1vd7xqn-gdb-15.2/lib/debug".

After

> /run/workspace/bin/gdb -q -x .gef.py -ex 'show debug-file-directory' -ex 'quit'
The directory where separate debug symbols are searched for is "/nix/store/k51rfv38p65jbhw906vpl85yg1vd7xqn-gdb-15.2/lib/debug:/usr/lib/debug".
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 893155c 🟢

Old New
Commit 7638efe 893155c
Score 71.1152% 71.1152% (0)

@tesuji tesuji force-pushed the fallback-dbgsym-path branch from 893155c to a5fb11d Compare February 12, 2025 06:55
@github-actions GitHub Actions
Copy link

🤖 Coverage update for a5fb11d 🟢

Old New
Commit 7638efe a5fb11d
Score 71.1152% 71.1152% (0)

Grazfather
Grazfather reviewed Feb 12, 2025
View reviewed changes
@tesuji tesuji force-pushed the fallback-dbgsym-path branch from a5fb11d to 568b195 Compare February 12, 2025 17:16
@github-actions GitHub Actions
Copy link

🤖 Coverage update for 568b195 🟢

Old New
Commit c430473 568b195
Score 71.1152% 71.1152% (0)

Grazfather
Grazfather previously approved these changes Feb 12, 2025
View reviewed changes
hugsy
hugsy requested changes Feb 13, 2025
View reviewed changes
@tesuji @hugsy
Update gef.py
bc5dceb 
Co-authored-by: crazy hugsy <hugsy@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

🤖 Coverage update for bc5dceb 🟢

Old New
Commit c430473 bc5dceb
Score 71.1152% 71.1152% (0)

@hugsy hugsy merged commit 57181d2 into hugsy:main Feb 13, 2025
6 checks passed
@tesuji tesuji deleted the fallback-dbgsym-path branch February 14, 2025 07:15
@hugsy hugsy mentioned this pull request Mar 15, 2025
Merged
4 tasks
hugsy added a commit that referenced this pull request Mar 16, 2025
@hugsy
Verify gdb.parameter("debug-file"directory") returns a string (#1177)
c631746 
## Description

This PR fixes a missing type check introduced by #1173 when getting
result from `gdb.parameter` while setting ` debug-file-directory`



Signed-off-by: hugsy <crazy.hugsy@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugsy hugsy hugsy approved these changes

@Grazfather Grazfather Grazfather left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect debug-file-directory for gdb installed by Nix
3 participants
@tesuji @Grazfather @hugsy
0