Fix flag of new content notification space #7014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-
requested changes
May 21, 2024
| @@ -91,7 +91,7 @@ public function init() | |||
| if ($this->space->isMember()) { | |||
| $membership = $this->space->getMembership(); | |||
|
|
|||
| if (!$membership->send_notifications) { | |||
| if (!$membership->send_notifications && !Yii::$app->notification->hasSpace($this->space)) { | |||
There was a problem hiding this comment.
Do we still need the !$membership->send_notifications check here?
There was a problem hiding this comment.
Yes, it may be deleted, If we will remove the !$membership->send_notifications from here the result is not changed because inside the method hasSpace() this checking is done too but there is an additional sql query to the table space_memberhip for all spaces.
I have decided to keep it here only to avoid the sql query when this setting is already enabled per current User and Space.
I.e. the removing will make the code cleaner but a bit slower.
There was a problem hiding this comment.
@yurabakhtin Thanks, then let's leave it as it is!
luke-
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
The PR fulfills these requirements:
Other information:
#7005