8000 InstallationState issues fix by gevorgmansuryan · Pull Request #7526 · humhub/humhub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

InstallationState issues fix #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 15, 2025
Merged

InstallationState issues fix #7526

merged 11 commits into from
May 15, 2025

Conversation

gevorgmansuryan
Copy link
Contributor

@gevorgmansuryan gevorgmansuryan requested a review from luke- May 15, 2025 19:02
@gevorgmansuryan gevorgmansuryan self-assigned this May 15, 2025
@what-the-diff What The Diff
Copy link
what-the-diff bot commented May 15, 2025 •
edited
Loading

PR Summary

  • Changelog Update
    Updated the CHANGELOG to include information on addressing issues related to the installationState.

  • Property Modification in InstallationState Class
    The state property in the InstallationState class has been modified from int to ?int to allow null values.

  • Logic Improvement in InstallationState Class
    The logic in the InstallationState class has been enhanced to assign the state based on certain conditions derived from the database configuration.

  • ModuleManager's Init Method Simplification
    The initialization method in ModuleManager has been simplified to only set enabledModules provided the database is appropriately configured.

  • Error Handling Update in ModuleManager
    The error handling in ModuleManager's registration method now throws an exception for console applications rather than calling Yii::$app->view->error().

  • SettingsLoader Modification
    SettingsLoader has been updated to define the user component configuration only if the application instance is an Application.

  • Deletion and Addition of Migration Files
    The old migration file, m241211_193138_reduce_dynamic_config.php has been removed. A new migration file, m250514_125129_reduce_dynamic_config.php has been added that sets the installation state and loads dynamic configuration from the database.

@gevorgmansuryan gevorgmansuryan marked this pull request as draft May 15, 2025 19:28
@gevorgmansuryan gevorgmansuryan marked this pull request as ready for review May 15, 2025 19:42
@gevorgmansuryan gevorgmansuryan requested a review from luke- May 15, 2025 19:59
@luke- luke- added this pull request to the merge queue May 15, 2025
Merged via the queue into develop with commit 03d16b6 May 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke- luke- luke- approved these changes

Assignees

@gevorgmansuryan gevorgmansuryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gevorgmansuryan @luke-
0