8000 PyPI publish follow-up by briantist · Pull Request #1004 · hvac/hvac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PyPI publish follow-up #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2023
Merged

PyPI publish follow-up #1004

merged 3 commits into from
Jun 17, 2023

Conversation

briantist
Copy link
Contributor

Follow-up to #1002

  • Artifact download path was not set, so publishing and asset attachment did not work; fixed that
  • Added a tree output to help diagnose these things better in the future
  • The asset job "succeeded" with a warning when it couldn't match files, not it will fail

Just as before, this can't be tested in PR form. Will merge, then re-release.

@briantist briantist added skip-changelog will not be shown in the auto-generated changelog maintenance General technical debt labels Jun 17, 2023
@briantist briantist self-assigned this Jun 17, 2023
@briantist briantist requested a review from a team as a code owner June 17, 2023 19:59
@codecov
Copy link
codecov bot commented Jun 17, 2023

Codecov Report

Merging #1004 (b80b0ed) into main (ceceeee) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   82.08%   82.04%   -0.04%     
==========================================
  Files          65       65              
  Lines        3019     3019              
==========================================
- Hits         2478     2477       -1     
- Misses        541      542       +1

see 1 file with indirect coverage changes

@briantist briantist merged commit 31aca14 into hvac:main Jun 17, 2023
@briantist briantist deleted the publish/pypi-oidc branch June 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briantist briantist

Labels
maintenance General technical debt skip-changelog will not be shown in the auto-generated changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@briantist
0