8000 aws auth - add support for `iam_metadata` and `ec2_metadata` params by danholodak · Pull Request #1125 · hvac/hvac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

aws auth - add support for iam_metadata and ec2_metadata params #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2024
Merged

aws auth - add support for iam_metadata and ec2_metadata params #1125

merged 3 commits into from
Jan 27, 2024

Conversation

danholodak
Copy link
Contributor
@danholodak danholodak commented Jan 23, 2024 •
edited by briantist
Loading

Resolves #1029

  • Support the 2 metadata parameters for AWS configure identity integration
  • Add integration tests for configure_identity_integration

@danholodak danholodak requested a review from a team as a code owner January 23, 2024 05:01
@danholodak danholodak mentioned this pull request Jan 23, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7688e2) 87.38% compared to head (fa8b3a0) 87.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   87.38%   87.66%   +0.27%     
==========================================
  Files          66       66              
  Lines        3227     3227              
==========================================
+ Hits         2820     2829       +9     
+ Misses        407      398       -9
Files Coverage Δ
hvac/api/auth_methods/aws.py 63.52% <100.00%> (+5.66%) ⬆️

@briantist briantist self-assigned this Jan 23, 2024
@briantist briantist changed the title Fix #1029: Add support for iam_metadata and ec2_metadata params Add support for iam_metadata and ec2_metadata params Jan 23, 2024
@briantist briantist added aws AWS auth method and/or secrets engine enhancement a new feature or addition auth methods generally related to a Vault auth method minor Used as part of release-drafter's version-resolver configuration labels Jan 23, 2024
@briantist briantist added this to the 2.2.0 milestone Jan 23, 2024
briantist
briantist reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor
@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danholodak ! I didn't look closely at the tests yet, just some initial comments. You'll also want to be sure you run the black formatter (and other linters) before committing:

poetry run black .
poetry run flake8 .
poetry run typos

@danholodak
Copy link
Contributor Author

Thanks for the quick review, I believe I've addressed all the comments and I ran the linters. Looking forward to your thoughts on the tests.

briantist
briantist reviewed Jan 24, 2024
View reviewed changes
@briantist
Copy link
Contributor

minor ask: I would prefer if you don't squash commits on your end for the most part. It's helpful for me to see individual commits so I can review individual changes as we go along. I know some projects use "conventional commits" or have that workflow; in this project all commits in a PR are squashed into one on merge anyway, so no need to like "clean up" the commits locally.

If you really like to do it that way you can, it might slow me down a bit though, just my preference.

@danholodak
Copy link
Contributor Author

minor ask: I would prefer if you don't squash commits on your end for the most part.

Totally happy not to squash going forward, thanks for letting me know.

briantist
briantist reviewed Jan 27, 2024
View reviewed changes
Copy link
Contributor
@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two final documentation nits, which I'll take care of committing

briantist
briantist approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor
@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danholodak thanks very much for this contribution!

@briantist briantist changed the title Add support for iam_metadata and ec2_metadata params aws auth - add support for iam_metadata and ec2_metadata params Jan 27, 2024
@briantist briantist merged commit 8cb35eb into hvac:main Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
auth methods generally related to a Vault auth method aws AWS auth method and/or secrets engine enhancement a new feature or addition minor Used as part of release-drafter's version-resolver configuration
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Add support for iam_metadata within aws identity integration
2 participants
@danholodak @briantist
0