feat: Raft Autopilot endpoints #1176
Conversation
|
thanks @kayra1 and welcome! It'll take me a little time to review this more closely. In the meantime, take a look at the lint/test runs in CI, consider running linting, formatting, and tests locally to enable more rapid iteration so you don't have to wait for CI (I have to approve each new push for first time contributors). cc @tot19 since I think you were interested as well |
|
will do, thanks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 87.56% 87.38% -0.18%
==========================================
Files 67 67
Lines 3288 3298 +10
==========================================
+ Hits 2879 2882 +3
- Misses 409 416 +7
|
|
hello @briantist . I was just wondering if there was anything missing from my end about this. |
|
@kayra1 I have not had a chance to look over it in detail. I would like to see more test coverage if possible. I know we don't use raft in the tests at all so integration is probably not feasible but unit tests might be. |
|
@briantist I was basing the files i changed to this PR, which seems to have done something similar. I will investigate the unit tests and add some if I can, a 8435 nd let you know if I run into any issues. |
closes #1165
This adds 3 endpoints from the autopilot feature of Vault as described in the issue #1165 .
I locally validated and wrote tests for these functions, but I added a skip reason stating that the integration tests currently only support Consul. I am not too familiar with the testing setup in this repo, but let me know if there is anything I can address there.
Thanks.