8000 docs: fix AppRole.login docstring by evan-cohen · Pull Request #1182 · hvac/hvac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix AppRole.login docstring #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

evan-cohen
Copy link
Contributor

Corrects the return description in the docstring of of api.auth_methods.AppRole.login

@evan-cohen evan-cohen requested a review from a team as a code owner July 27, 2024 10:13
@briantist briantist self-assigned this Jul 29, 2024
@briantist briantist added documentation documentation updates and/or requests for expanded documentation auth methods generally related to a Vault auth method approle AppRole auth method patch Used as part of release-drafter's version-resolver configuration labels Jul 29, 2024
Copy link
Contributor
@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-cohen thanks for this documentation fix!

@briantist briantist added this to the 2.4.0 milestone Jul 29, 2024
Copy link
codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (b76e0ed) to head (75a23cc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          67       67           
  Lines        3288     3288           
=======================================
  Hits         2879     2879           
  Misses        409      409           
Files with missing lines Coverage Δ
hvac/api/auth_methods/approle.py 100.00% <ø> (ø)

@briantist briantist merged commit 2d2c80e into hvac:main Jul 29, 2024
36 checks passed
@evan-cohen evan-cohen deleted the approle-login-docstring branch March 29, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approle AppRole auth method auth methods generally related to a Vault auth method documentation documentation updates and/or requests for expanded documentation patch Used as part of release-drafter's version-resolver configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0