8000 Remove python 3.8 and vault versions 1.11 and 1.12 for next major release by clintonsteiner · Pull Request #1196 · hvac/hvac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove python 3.8 and vault versions 1.11 and 1.12 for next major release #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove python 3.8 and vault versions 1.11 and 1.12 for next major release #1196

wants to merge 3 commits into from

Conversation

clintonsteiner
Copy link

No description provided.

@clintonsteiner clintonsteiner requested a review from a team as a code owner November 22, 2024 06:32
@clintonsteiner clintonsteiner force-pushed the removePython38_addNewVersions branch from f0bd663 to f41e481 Compare November 22, 2024 06:34
@clintonsteiner clintonsteiner mentioned this pull request Nov 22, 2024
Open
@briantist briantist added this to the 3.0.0 milestone Nov 22, 2024
@briantist briantist self-assigned this Nov 22, 2024
@briantist
Copy link
Contributor
briantist commented Nov 22, 2024 •
edited
Loading

In accordance with the policy removing a python version needs to be done in a major release.

The PR could be split to add newer Vault versions without a major release, but if we want to remove any Vault versions that should also be done in a major release. I'm not sure if we want to add two more without removing some though, due to limited CI resources.

@clintonsteiner
Copy link
Author

Sounds like this 8000 just needs to wait for a major release in that case? Thanks for taking the time to review

@briantist
Copy link
Contributor

it looks like there are a number of failures to address before this could be merged

@clintonsteiner
add support for python 3.13
f819eeb 
* greenlet package required version bump to 3.10 which is minimum with
  support for python3.13
* hvac#1196 per pr - python 3.8 will be
  dropped in major release
@clintonsteiner clintonsteiner mentioned this pull request Dec 16, 2024
Open
@clintonsteiner clintonsteiner force-pushed the removePython38_addNewVersions branch from f41e481 to aa80ab7 Compare December 16, 2024 14:57
@clintonsteiner clintonsteiner changed the title drop python 3.8 from ci, add vault releases 1.17 and 1.18 Remove python 3.8 and vault versions 1.11 and 1.12 for next major release Dec 16, 2024
@clintonsteiner
Copy link
Author

Rebased on other branches - this change can be merged before the next major release and features the removals of functionality
#1201 adds python 3.13 support
#1200 bumps gha version
#1199 adds vault version 1.17 and 1.18 for testing

@briantist
Copy link
Contributor

Thanks for these PRs @clintonsteiner ! I'm trying to figure out what's causing the timeouts in Vault 1.16+. Even #1183 which is an old dependabot PR that was passing previously is having the issue now so I don't think it has anything to do with your submissions, but we should have them passing. Since #1199 is also demonstrating the issue consistently in the new Vault versions I suspect some change was made in Vault and backported to 1.16 I just don't know what it is yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briantist briantist

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clintonsteiner @briantist
0