rename galaxy to root and guardian to superadmin #9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces references to “galaxy” with “root” and “guardian” with “superadmin” across the access authorization logic and tests. The changes update namespace constants, error messages, function names, and related test assertions.
- Changed predicate prefix functions and namespace constants from Galaxy to Root.
- Updated account upsert and authorization functions from Guardian to SuperAdmin.
- Modified test files to use the new Root namespace and SuperAdmin identifiers.
Reviewed Changes
Copilot reviewed 101 out of 101 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| edgraph/access.go | Renamed constant functions and error messages to use Root/SuperAdmin. |
| dgraphtest/local_cluster.go | Updated login namespaces from Galaxy to Root. |
| dgraphtest/load.go | Updated login namespaces from Galaxy to Root. |
| dgraph/cmd/zero/* | Replaced Galaxy namespace usage with Root namespace in various handlers. |
| dgraph/cmd/live/run.go | Modified logic and error messages to reflect superadmin usage. |
| dgraph/cmd/alpha/* and acl/* | Updated login and messaging for ACL tests from Galaxy to Root. |
Comments suppressed due to low confidence (1)
edgraph/access.go:1138
- [nitpick] Consider updating the error message to use 'superadmin' instead of 'guardians' for consistency with the new naming convention.
s.Code(), "AuthSuperAdmin: failed to authorize guardians. " + s.Message()
|
|
harshil-goel
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.