make v25 APIs work with no ACL #9408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the APIs to work with no ACL by modifying error messages and function signatures to remove outdated ACL-related parameters.
- Updates error message ordering for ACL key length validation.
- Adjusts the createGuardianAndGroot function calls to match its new signature.
- Adds an integration test to ensure the v25 API operates correctly without ACL enforcement.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| x/acl_enc_keys.go | Revised error message parameters for ACL key length validation. |
| edgraph/ns_query_no_acl_test.go | Added integration tests to verify namespace operations without ACL. |
| edgraph/multi_tenancy.go | Updated createGuardianAndGroot function call to remove unused arg. |
| edgraph/alter.go | Aligned createGuardianAndGroot invocation with its updated signature. |
harshil-goel
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.