Fix running tests on mac #9441
Merged
Fix running tests on mac #9441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the way docker is setup on Mac (with a layer of linux VM in between the container and mac host), docker inspect does not know about port mapping from host to container. We instead use docker ps on Mac to get the port mappings.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with running tests on macOS by using "docker ps" instead of "docker inspect" to retrieve port mappings, addressing the macOS-specific behavior of Docker.
- Added a conditional branch to use getPortMappingsOnMac on Darwin.
- Introduced a new function getPortMappingsOnMac to parse port mappings from "docker ps" output.
harshil-goel
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the way docker is setup on Mac (with a layer of linux VM in between the container and mac host),
docker inspectdoes not know about port mapping from host to container. We instead usedocker pson Mac to get the port mappings.