Implement asset selection logic for download counting #4696
+573
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a helper to improve how release assets are selected for download counting and updates the counting logic to use it, backed by extensive new tests.
- Added
_find_target_assetinbase.pyto pick assets by configured filename, plugin patterns, manifest filename, or fallback. - Updated
common_update_datato use the new helper for settingdata.downloads. - Introduced many new tests and snapshot fixtures covering various asset selection scenarios.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| custom_components/hacs/repositories/base.py | Imported GitHubReleaseAssetModel, updated common_update_data, and added _find_target_asset. |
| tests/repositories/test_download_counting.py | Added comprehensive unit tests for asset selection and download counting. |
| tests/snapshots/api-usage/tests/repositories/*.json | Added snapshot JSON fixtures for each new test scenario to verify API usage. |
Comments suppressed due to low confidence (1)
tests/snapshots/api-usage/tests/repositories/test_download_countingtest-regression-plugin-pattern-matching.json:1
- Snapshot filename
test_download_countingtest-regression-plugin-pattern-matching.jsonappears to combine two names without a separator. Consider renaming to include a clear delimiter or subdirectory (e.g.,test_download_counting/test-regression-plugin-pattern-matching.json) for consistency and proper snapshot mapping.
{
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the asset selection logic for download counting in the
hacsrepository, along with comprehensive test coverage for various scenarios. The most notable changes include the addition of a helper method to identify the correct asset for download, updates to the download counting logic, and new test cases to ensure robustness.Asset Selection Enhancements:
custom_components/hacs/repositories/base.py: Added_find_target_assetmethod to intelligently se 8000 lect the correct asset based on filename, plugin patterns, manifest filename, or fallback to the first asset.common_update_datamethod to use_find_target_assetfor determining the download count.fixes #4438