8000 [2.8.0] pre-built binary releases for Linux and Mac report version as UNKNOWN · Issue #730 · hadolint/hadolint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[2.8.0] pre-built binary releases for Linux and Mac report version as UNKNOWN #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 3 tasks
robert914 opened this issue Nov 5, 2021 · 4 comments · Fixed by #732
Closed
2 of 3 tasks

[2.8.0] pre-built binary releases for Linux and Mac report version as UNKNOWN #730

robert914 opened this issue Nov 5, 2021 · 4 comments · Fixed by #732

Comments

@robert914
Copy link
robert914 commented Nov 5, 2021 •
edited
Loading
  • This is a bug report
  • This is a feature request
  • I searched existing issues before opening this one

The -v/--version output reports UNKNOWN for the pre-compiled release binaries distributed here: https://github.com/hadolint/hadolint/releases/tag/v2.8.0

Expected behavior

On Mac:

❯ ./hadolint-Darwin-x86_64 -v
Haskell Dockerfile Linter 2.8.0-no-git

On Linux:

❯ ./hadolint-Linux-x86_64 -v
Haskell Dockerfile Linter 2.8.0-no-git

Actual behavior

On Mac:

❯ ./hadolint-Darwin-x86_64 -v
Haskell Dockerfile Linter UNKNOWN

On Linux:

❯ ./hadolint-Linux-x86_64 -v
Haskell Dockerfile Linter UNKNOWN

Steps to reproduce the behavior

See above.

Dockerfile (if relevant)

N/A

Additional environment details (OS, stack version, etc.)

Mac or Linux OS versions, possibly Windows (untested).
@robert914 robert914 changed the title [2.8.0] pre-built binary releases for Linux and Mac (possibly Windows) have UNKNOWN version [2.8.0] pre-built binary releases for Linux and Mac report version as UNKNOWN Nov 5, 2021
@lorenzo
Copy link
Member
lorenzo commented Nov 5, 2021

no idea why, must be some change in the CI which I'm unaware of. Help appreciated

@dmpe
Copy link
dmpe commented Nov 9, 2021

Jop, can also confirm that.

@mjsteinbaugh
Copy link

I'm seeing this on macOS with Homebrew binary for v2.8.0.

@darkvertex
Copy link

The Windows binary has this issue too.

@darkvertex darkvertex mentioned this issue Nov 9, 2021
Open
@hpedrorodrigues hpedrorodrigues mentioned this issue Nov 10, 2021
Closed
3 tasks
m-ildefons added a commit to m-ildefons/hadolint that referenced this issue Nov 10, 2021
@m-ildefons
bugfix: display version string correctly
daee7f1 
Construct the version string correctly when not compiling in a git
directory.
This bug was caused by a typo and a misunderstanding of the code when
the version string logic was moved from app/Main.hs to
src/Hadolint/Meta.hs in commit 3b1de5a

fixes: hadolint#730
@m-ildefons m-ildefons mentioned this issue Nov 10, 2021
Merged
lorenzo pushed a commit that referenced this issue Nov 10, 2021
@m-ildefons
bugfix: display version string correctly (#732)
0b25353 
Construct the version string correctly when not compiling in a git
directory.
This bug was caused by a typo and a misunderstanding of the code when
the version string logic was moved from app/Main.hs to
src/Hadolint/Meta.hs in commit 3b1de5a

fixes: #730
@elchenberg elchenberg mentioned this issue Dec 22, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: display version string correctly m-ildefons/hadolint
5 participants
@lorenzo @robert914 @darkvertex @mjsteinbaugh @dmpe
0