8000 Feature: Silence DL3020 even for doube quoted URLs #693 by datYori · Pull Request #695 · hadolint/hadolint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature: Silence DL3020 even for doube quoted URLs #693 #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2021
Merged

Feature: Silence DL3020 even for doube quoted URLs #693 #695

merged 1 commit into from
Sep 3, 2021

Conversation

datYori
Copy link
Contributor
@datYori datYori commented Aug 26, 2021

What I did

Added ignore case to DL3020

fixes #693

How I did it

Added two more string to test against

How to verify it

ADD "https://dl.k8s.io/release/v1.21.0/bin/linux/amd64/kubectl" /tmp

should not trigger DL3020 anymore

@lorenzo
Copy link
Member
lorenzo commented Aug 26, 2021

what's the meaning of the quotes?

@datYori
Copy link
Contributor Author
datYori commented Aug 26, 2021

sometimes you have substitution inside your URL, then it is good practice to quote it

ENV K8VERSION=1.21.0

ADD "https://dl.k8s.io/release/v$K8VERSION/bin/linux/amd64/kubectl" /tmp

@lorenzo lorenzo merged commit 16b8ec9 into hadolint:master Sep 3, 2021
@lorenzo
Copy link
Member
lorenzo commented Sep 3, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DL3020 Use COPY instead of ADD for URLs : False Positive
2 participants
@datYori @lorenzo
0