8000 WriteURL causes hashchange event which unnecessarily calls slide() a second time · Issue #529 · hakimel/reveal.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WriteURL causes hashchange event which unnecessarily calls slide() a second time #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmp opened this issue Jul 19, 2013 · 1 comment
Closed

WriteURL causes hashchange event which unnecessarily calls slide() a second time #529

gmp opened this issue Jul 19, 2013 · 1 comment

Comments

@gmp
Copy link
gmp commented Jul 19, 2013

When the delayed call to writeURL runs, it updates the window URL that triggers a 'hashchange' event, which in turn causes slide() and therefore updateSlides() to run a second time.

For example, when the page loads, slide() is called and then 1500ms later writeURL updates the URL hash to the current slide index. This causes readURL to call slide() again.

I could be missing something, but I don't believe this second call to slide() is necessary if the slide hasn't actually been updated--just the URL hash to reflect the current position.
gmp added a commit to gmp/reveal.js that referenced this issue Jul 19, 2013
@gmp
silence 'hashchange' event on writeURL delay fixes hakimel#529
4d75335
hakimel added a commit that referenced this issue Jul 19, 2013
@hakimel
only call slide() after hash changes if indices have changed #529
8dcf324
@hakimel
Copy link
Owner
hakimel commented Jul 19, 2013

Was looking at #530 and decided to check this out too. I've added a fix to the dev branch and as far as I can tell from some basic testing it's working well. 8dcf324

@hakimel hakimel closed this as completed Jul 19, 2013
hakimel added a commit that referenced this issue Jul 21, 2013
@hakimel
correction to bug introduced via #529
4a68d2d
enovajuan pushed a commit to enovajuan/reveal.js that referenced this issue Dec 2, 2014
@hakimel
only call slide() after hash changes if indices have changed hakimel#529
6cceb62
enovajuan pushed a commit to enovajuan/reveal.js that referenced this issue Dec 2, 2014
@hakimel
correction to bug introduced via hakimel#529
df6ff72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakimel @gmp
0