8000 Leapmotion plugin by roryhardy · Pull Request #554 · hakimel/reveal.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Leapmotion plugin #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 8, 2013
Merged

Leapmotion plugin #554

merged 13 commits into from
Aug 8, 2013

Conversation

roryhardy
Copy link
Contributor

The leap motion plugin is finished.

It has a pointer which can change size based on finger position along the z-axis. It also, by default, will set the origin for the pointer (center of the screen) relative to where you initially enter the leap's detection field. This feature is optional.

Supports one hand left, right, up, and down swipe gestures with optional invert.

Supports two hands up swipe gesture to toggle the overview.

It has 8 overridable options to curtail the experience as needed.

I had a few people with varying levels of familiarity to the leap motion try it out and received positive feedback.

Rory Hardy and others added 13 commits August 3, 2013 22:33
Left, right, up, and down gestures.
Optional invert for gestures.
Added timing code to limit gesture calls.
Added gesture to access the overview.
index.html includes the leap plugin
Changed invert to naturalSwipe
Removed invert rule from index.html
Ensured that left/right swipes only work with 1 hand present
modified:   index.html
modified:   plugin/leap/leap.js
When used correctly, the 1/2 second delay is uncessary and may yield undesireable results.
modified:   plugin/leap/leap.js
modified:   css/reveal.css
modified:   css/reveal.min.css
modified:   plugin/leap/leap.js
Occasionally gestures were fired twice. This helps prevent that.
modified:   plugin/leap/leap.js
modified:   css/reveal.min.css
modified:   plugin/leap/leap.js
Updated README.md to mention the leap plugin.
Removed leap settings from index.html.
Better variable naming in leap.js

modified:   README.md
modified:   index.html
modified:   plugin/leap/leap.js
Enhanced the pointer.
Cleaned up the code.
Added additional optional parameters.
Updated documentation.

modified:   README.md
modified:   index.html
modified:   plugin/leap/leap.js
modified:   plugin/leap/leap.js
Commented out leap plugin inclusion.
Made sure all vars are declared with the var keyword.
	modified:   plugin/leap/leap.js
@hakimel
Copy link
Owner
hakimel commented Aug 8, 2013

Thanks a ton for this! I don't have a device to test on but everything looks good in the diff. Will merge it in shortly.

hakimel pushed a commit that referenced this pull request Aug 8, 2013
@hakimel
Copy link
Owner
hakimel commented Aug 8, 2013

Merged into the dev branch https://github.com/hakimel/reveal.js/commits/dev

Will make its way into master with the next release.

hakimel added a commit 8000 that referenced this pull request Aug 8, 2013
@hakimel hakimel merged commit 8c1923b into hakimel:master Aug 8, 2013
@hakimel
Copy link
Owner
hakimel commented Aug 8, 2013

Went ahead and merged this into master, didn't want to wait for dev to be merged :)

@roryhardy
Copy link
Contributor Author

No problem at all! It was really fun :)

@hakimel hakimel mentioned this pull request Aug 10, 2013
hakimel added a commit that referenced this pull request Aug 11, 2013
@hakimel
Copy link
Owner
hakimel commented Aug 11, 2013

Made a small change to this, since there were so few styles in the reveal.css file I figure it'd be nice to have it all in the leap.js file.

@roryhardy
Copy link
Contributor Author

Yeah I suppose. I tend to prefer static styles to just be defined as CSS myself, but this works too.

@clauxz
Copy link
clauxz commented Sep 24, 2013

leap.js plugin in reveal has flaw call to function i think is outdated, and could not detect the leap motion on latest leap motion software upgrade, I tried to change the call to function from official https://github.com/leapmotion/leapjs and change the function and could detect swipe but not the pointer

in addition any plans to get master supporting to the leap plugin.. its quite confusing as the official documentation has leap motion plugin support but the master still do not support leap plugin ..

By the first first time poster, forgive me for any mistake

@roryhardy
Copy link
Contributor Author

Can anyone duplicate this? I am unable to duplicate it.

The plugin is in master: https://github.com/hakimel/reveal.js/tree/master/plugin/leap

@roryhardy roryhardy deleted the leapmotion-plugin branch September 24, 2013 13:57
@clauxz
Copy link
clauxz commented Sep 25, 2013

Ahhh apologize nubie mistake .. your code works, i got mess up with master code , official leap.js with your fork that do not have the pointer functions..
.. please ignore my earlier issues ..

However .. master index.html is not linked to the leap plugin, thats why i could not get it to work straight from cloning the reveal.js any plans to link index.html it to the leap motion

by the way great plugin, love the leap motion plugin..

Sorry, first time poster and still learning the rope

enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014
enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014
enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0