8000 min and max in the algorithm was confusing loop partitioning by abadams · Pull Request #5355 · halide/Halide · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

min and max in the algorithm was confusing loop partitioning #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

min and max in the algorithm was confusing loop partitioning #5355

merged 1 commit into from
Oct 13, 2020

Conversation

abadams
Copy link
Member
@abadams abadams commented Oct 12, 2020

Because if any likely tag at all existed on a side of the min/max, even
if captured, the other side wasn't getting mutated. This should only
happen for uncaptured likelies, where simplifications in the unlikely
path are irrelevant.

Fixes #5353

@abadams
min and max in the algorithm was confusing loop partitioning
91a22ad 
Because if any likely tag at all existed on a side of the min/max, even
if captured, the other side wasn't getting mutated. This should only
happen for uncaptured likelies, where simplifications in the unlikely
path are irrelevant.
@abadams abadams added the backport me This change should be backported to release versions label Oct 12, 2020
@steven-johnson steven-johnson merged commit 47a5a44 into master Oct 13, 2020
@steven-johnson steven-johnson deleted the abadams/fix_5353 branch October 13, 2020 16:03
@abadams abadams added this to the v10.0.1 milestone Oct 16, 2020
@alexreinking alexreinking removed the backport me This change should be backported to release versions label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.0.1
Development

Successfully merging this pull request may close these issues.

When given a concrete buffer, code doesn't partition loops.
3 participants
@abadams @steven-johnson 328C @alexreinking
0