Add a feature to name cached memoizations and to evict them by name. #5510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 2, 2020 00:20
Add test case with a called extern to set the eviction key.
|
The build failures should go away if you sync to master. EDIT: took the liberty of doing so myself after the builtbots restarted. |
dsharletg
reviewed
Dec 4, 2020
| CacheEntry **prev = &cache_entries[i]; | ||
| while (entry != nullptr) { | ||
| CacheEntry *next = entry->next; | ||
| if (entry->has_eviction_key && entry->eviction_key == eviction_key) { |
There was a problem hiding this comment.
Can this list removal be in a helper function? It looks like all the other potential uses are removing from the end and so are a bit simpler, but I think maybe it would be better if they all used a more general list removal helper anyways?
…re calling convention evolution.
|
Not sure how to resolve the merge conflict here. |
steven-johnson
approved these changes
Dec 17, 2020
|
Looks good, ready to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @dsharletg, this allows "naming" memoizations with 64-bits and then evicting entries by using that name. The name is not part of the cache key and is user chosen. A pointer value, a hash of image data, or a monotonic counter are all possibilities for cache eviction names.
I have a small design doc in progress that I will share shortly. It covers the possibility of using multiple typed names of this sort to allow caching CPU allocations as well. (The runtime automatically adds the GPU context as an eviction name and whenever a GPU context is freed, its bit value is used to evict all allocations on that context from the memoization cache.)
Wanted to get the review/buildbot process started here.
Addresses the second item in issue #5465 .