Backport #5624 to 11.0.0 (Fix cuda warp shuffle issue for narrow types) #5669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix cuda warp shuffle issue for narrow types In the case where no shuffle was necessary, we were upcasting the type to 32-bits needlessly and causing chaos. (cherry picked from commit 57083e4)
abadams
approved these changes
Jan 26, 2021
|
Failures look unrelated to CUDA, should this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: Fix cuda warp shuffle issue for narrow types (#5624)
In the case where no shuffle was necessary, we were upcasting the type to 32-bits needlessly and causing chaos.
(cherry picked from commit 57083e4)