Join generator watchdog timer if exception thrown #6240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to join the generator watchdog timer when an exception is thrown. Otherwise the error message gets swallowed entirely and you just get "terminate called without an active exception" Also rejiggered the watchdog to do a timed wait on a condition variable instead of polling every 100ms.
alexreinking
approved these changes
Sep 10, 2021
|
Failure is unrelated... looks like win-worker-1's LLVM trunk isn't building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to join the generator watchdog timer when an exception is
thrown. Otherwise the error message gets swallowed entirely and you just
get "terminate called without an active exception"
Also rejiggered the watchdog to do a timed wait on a condition variable
instead of polling every 100ms.