8000 Allow third parties to externally override SOVERSION by alexreinking · Pull Request #6534 · halide/Halide · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow third parties to externally override SOVERSION #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

alexreinking
Copy link
Member
@alexreinking alexreinking commented Jan 5, 2022

Debian and other third-party packagers might need or want to patch our sources for a variety of reasons. In those cases, they might also need to override the SOVERSION.

See here for a practical example:

https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch

ATTN @LebedevRI

Debian and other third-party packagers might need or want
to patch our sources for a variety of reasons. In those
cases, they might also need to override the SOVERSION.

See here for a practical example:

https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch
@alexreinking alexreinking added backport me This change should be backported to release versions build Issues related to building Halide and with CI labels Jan 5, 2022
@LebedevRI
Copy link
Contributor

Thanks, this will simplify things a bit!
Note the second part of that patch - in order to make the libHalide co-installable, we also override it's OUTPUT_NAME.

@alexreinking
Copy link
Member Author

Thanks, this will simplify things a bit! Note the second part of that patch - in order to make the libHalide co-installable, we also override it's OUTPUT_NAME.

My impression was that CMAKE_<CONFIG>_POSTFIX was sufficient for this.

@alexreinking alexreinking merged commit 7bb8198 into master Jan 5, 2022
@alexreinking alexreinking deleted the cmake/soversion-override branch January 5, 2022 21:44
@LebedevRI
Copy link
Contributor

@alexreinking thank you!

alexreinking added a commit that referenced this pull request Jan 5, 2022
Debian and other third-party packagers might need or want
to patch our sources for a variety of reasons. In those
cases, they might also need to override the SOVERSION.

See here for a practical example:

https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch
(cherry picked from commit 7bb8198)
@alexreinking alexreinking removed the backport me This change should be backported to release versions label Jan 5, 2022
alexreinking added a commit that referenced this pull request Jan 6, 2022
Debian and other third-party packagers might need or want
to patch our sources for a variety of reasons. In those
cases, they might also need to override the SOVERSION.

See here for a practical example:

https://salsa.debian.org/pkg-llvm-team/halide/-/blob/f881de70cd83095053e13047b63f61faf6bc7a36/debian/patches/0006-Fixup-libhalide-version-soversion-for-debian-package.patch
(cherry picked from commit 7bb8198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to building Halide and with CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0