8000 [HVX] Fix EliminateInterleaves by rootjalex · Pull Request #7279 · halide/Halide · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[HVX] Fix EliminateInterleaves #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2023
Merged

[HVX] Fix EliminateInterleaves #7279

merged 5 commits into from
Jan 20, 2023

Conversation

rootjalex
Copy link
Member

Minor fix for an edge case that introduces more shuffling.

Fixes #7100

@rootjalex rootjalex added performance hexagon Related to the hexagon (HVX) target labels Jan 16, 2023
@rootjalex rootjalex requested a review from pranavb-ca January 16, 2023 20:27
@rootjalex rootjalex changed the title Fix EliminateInterleaves [HVX] Fix EliminateInterleaves Jan 16, 2023
@rootjalex rootjalex mentioned this pull request Jan 17, 2023
Merged
@steven-johnson
Copy link
Contributor

Huh, the win32 failure is one I've never seen before:

FAILED: bin/li2018_demo_gradient_autoscheduler.exe 
li2018_demo_gradient.runtime.lib(li2018_demo_gradient.runtime.obj) : error LNK2019: unresolved external symbol ___floatundisf referenced in function _halide_profiler_report_unlocked

@rootjalex
Copy link
Member Author

Huh, the win32 failure is one I've never seen before:

FAILED: bin/li2018_demo_gradient_autoscheduler.exe 
li2018_demo_gradient.runtime.lib(li2018_demo_gradient.runtime.obj) : error LNK2019: unresolved external symbol ___floatundisf referenced in function _halide_profiler_report_unlocked

That is super weird, and entirely unrelated to this PR... Strange.

@steven-johnson
Copy link
Contributor

Huh, the win32 failure is one I've never seen before:

FAILED: bin/li2018_demo_gradient_autoscheduler.exe 
li2018_demo_gradient.runtime.lib(li2018_demo_gradient.runtime.obj) : error LNK2019: unresolved external symbol ___floatundisf referenced in function _halide_profiler_report_unlocked

That is super weird, and entirely unrelated to this PR... Strange.

Maybe related to something new/different in LLVM codegen?

@steven-johnson
Copy link
Contributor

Runtime Function: float __floatundisf (unsigned long i)
Runtime Function: double __floatundidf (unsigned long i)
Runtime Function: long double __floatunditf (unsigned long i)
Runtime Function: long double __floatundixf (unsigned long i)
These functions convert i, an unsigned long, to floating point.