8000 Added scrollability + fixed the issue of overflow - TimerEditor #133 by vpetrovic01 · Pull Request #134 · hamaluik/timecop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added scrollability + fixed the issue of overflow - TimerEditor #133 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added scrollability + fixed the issue of overflow - TimerEditor #133 #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
10000
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions lib/screens/timer/TimerEditor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ enum _DateTimeMenuItems { now }

class TimerEditor extends StatefulWidget {
final TimerEntry timer;

const TimerEditor({Key? key, required this.timer}) : super(key: key);

@override
Expand Down Expand Up @@ -146,11 +147,12 @@ class _TimerEditorState extends State<TimerEditor> {
),
body: Form(
key: _formKey,
child: Column(
//todo this should include a scrollable area
mainAxisSize: MainAxisSize.max,
mainAxisAlignment: MainAxisAlignment.start,
crossAxisAlignment: CrossAxisAlignment.stretch,
child: ListView(
// todo this should include a scrollable area
// mainAxisSize: MainAxisSize.max,
// mainAxisAlignment: MainAxisAlignment.start,
// crossAxisAlignment: CrossAxisAlignment.stretch,
shrinkWrap: true,
children: <Widget>[
BlocBuilder<ProjectsBloc, ProjectsState>(
builder: (BuildContext context, ProjectsState projectsState) =>
Expand Down Expand Up @@ -386,12 +388,16 @@ class _TimerEditorState extends State<TimerEditor> {
title: Text(L10N.of(context).tr.notes),
onTap: () async => await _editNotes(context),
),
Expanded(
ConstrainedBox(
constraints: const BoxConstraints(minHeight: 250, maxHeight: 880),
child: InkWell(
onTap: () async => await _editNotes(context),
child: Padding(
padding: const EdgeInsets.fromLTRB(16, 0, 16, 8),
child: Markdown(data: _notes!)))),
child: Markdown(
shrinkWrap: true,
physics: const NeverScrollableScrollPhysics(),
data: _notes!)))),
],
),
),
Expand Down
0