Drop C extension #1146
Drop C extension #1146
Conversation
|
@k0kubun I think this might have introduced an issue with the handling of a hash value for %div{ aria: { label: 'foo' } }Would compile to this: <div aria-label='foo'></div>Now, on 6.2, it compiles to this: <div aria='{:label=>"foo"}'></div>I think it's due to |
|
Can you prepare a repository that reproduces it? I cannot reproduce your issue locally. We also have a test case similar to it https://github.com/haml/haml/blob/v6.2.0/test/haml/engine/old_attribute_test.rb#L387-L393 and it's passing. $ irb -rhaml
irb(main)[01:0]> RUBY_DESCRIPTION
=> "ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]"
irb(main)[02:0]> Haml::VERSION
=> "6.2.0"
irb(main)[03:0]> Haml::Template.new { "%div{ aria: { label: 'foo' } }" }.render
=> "<div aria-label='foo'></div>\n" |
|
OK, I managed to make a reproducible issue from the code you pointed out: $ irb -rhaml
irb(main)[01:1]" Haml::Template.new { <<~EOS }.render
irb(main)[02:1]" - hash = { aria: { label: 'foo' } }
irb(main)[03:1]" %div{ hash }
irb(main)[04:0]> EOS
=> "<div aria='{:label=>"foo"}'></div>\n"I don't think the |
|
Fixed in v6.2.1. |
|
Fixed another |
|
Whoops, yes that is actually exactly what my templates are doing (technically |
ERB::Escapein Ruby 3.2 and now Haml uses it Let Haml::Util.escape_html use ERB::Escape #1145.rb_funcallcalls. As we optimize YJIT further, YJIT-optimized Ruby code might potentially outperform this C extension since Ruby -> C -> Ruby calls are somewhat expensive by nature.