Convert Part generator to use RubyFileWriter and Generate::Command #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-writer-to-action
Base automatically changed from
expand-use-of-ruby-file-writer-to-action
to
main
April 18, 2025 21:36
cllns
added a commit
that referenced
this pull request
Apr 24, 2025
* Rename to partially_qualified_parent * Rename to fully_qualified_parent * Convert Operation generator to use RubyClassFile * Convert Relation generator to use RubyClassFile * Convert Repo generator to use RubyClassFile * Convert Struct generator to use RubyClassFile * Convert Repo generator to use RubyClassFile * Convert Component generator to use RubyClassFile * Remove RubyFileWriter, in favor of RubyClassFile * Remove un-used ERB files Clean up from #292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #288
After this is merged, I want to refactor some of this. I don't love the names
relative_parent_class(gets the app/slice namespace prepended) andabsolute_parent_class. Considering using qualified/unqualified but that's not super clear either. Any ideas?parent_classandparent_class_within_namespace?In that PR, I'll also go through and change all references to RubyFileWriter to RubyClassFile, since that's the API we want to use going forward.