8000 textDocument/complete: Provide completion in incomplete blocks · Issue #57 · hashicorp/terraform-ls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

textDocument/complete: Provide completion in incomplete blocks #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
radeksimko opened this issue Apr 21, 2020 · 2 comments
Open

textDocument/complete: Provide completion in incomplete blocks #57

radeksimko opened this issue Apr 21, 2020 · 2 comments
Labels
enhancement New feature or request textDocument/completion upstream/hcl

Comments

@radeksimko
Copy link
Member

Server Version

v0.1.0

Terraform Version

v0.12.24

Terraform Configuration Files

provider "aws" {
}
resource "aws_vpc" "name" {
}
data ""

Log Output

2020/04/21 11:11:11 rpc_logger.go:45: Error for "textDocument/completion" (ID 6): [-32098] finding HCL block failed: no block found at hcl.Pos{Line:5, Column:7, Byte:55}

Expected Behavior

A list of all AWS data sources offered as completion candidates.

(assuming that completion of data source names per #19 is implemented)

Actual Behavior

No completion available.

Steps to Reproduce

  1. Open a folder with the above config
  2. Open file with the above config from that folder
  3. Trigger autocompletion on line 5, column 7 (1-indexed) - i.e. data "<HERE>"

Proposal

hashicorp/hcl#365 is key to make this work - in theory when it's addressed and we upgrade to the HCL version with that patch it should be just resolved.
This was referenced Apr 21, 2020
Closed
Closed
radeksimko added a commit that referenced this issue Apr 21, 2020
@radeksimko
hcl: Ignore parsing errors
c5cbd3a 
This doesn't actually enable completion for invalid configs yet
but it paves the way for #56 and #57
@paultyng paultyng added this to the v0.3.0 milestone May 7, 2020
@radeksimko radeksimko mentioned this issue May 12, 2020
Closed
@paultyng paultyng mentioned this issue May 14, 2020
Closed
@radeksimko
Copy link
Member Author

This is temporarily being de-prioritised in favour of #18 which is slightly easier and quicker to solve and can address at least cases where user uses completion to create the block.

@radeksimko radeksimko removed this from the v0.3.0 milestone May 19, 2020
@radeksimko radeksimko added the lsp label Jul 29, 2020
@radeksimko radeksimko removed the lsp label Aug 5, 2021
This was referenced Aug 10, 2021
Closed
Open
This was referenced Jul 24, 2022
Open
Closed
@dbanck dbanck mentioned this issue Apr 18, 2023
Open
@radeksimko radeksimko mentioned this issue Aug 30, 2023
Closed
1 task
@dme86
Copy link
dme86 commented Feb 5, 2024

Is this included in any roadmap, or is there a quick fix available?

@dbanck dbanck mentioned this issue Apr 25, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request textDocument/completion upstream/hcl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@radeksimko @paultyng @dme86
0