8000 datasource ids by koikonom · Pull Request #118 · hashicorp/terraform-provider-ad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

datasource ids #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

datasource ids #118

merged 1 commit into from
Jun 9, 2021

Conversation

koikonom
Copy link
Contributor
@koikonom koikonom commented Jun 8, 2021

Introduce ID parameters for datasources

@koikonom koikonom requested review from appilon and megan07 June 8, 2021 20:43
@ghost ghost added the size/XXL label Jun 8, 2021
@koikonom koikonom changed the base branch from main to dh_v2 June 8, 2021 20:43
Copy link
@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Use a single general purpose ID field for datasources when possible.
@ghost ghost added size/S and removed size/XXL labels Jun 9, 2021
@koikonom koikonom changed the base branch from dh_v2 to main June 9, 2021 17:47
@koikonom koikonom merged commit e2ee0dd into main Jun 9, 2021
@koikonom koikonom deleted the datasource_ids branch June 9, 2021 17:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0