8000 Upgrade to SDK v2 by koikonom · Pull Request #37 · hashicorp/terraform-provider-ad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to SDK v2 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 31, 2020
Merged

Upgrade to SDK v2 #37

merged 7 commits into from
Jul 31, 2020

Conversation

koikonom
Copy link
Contributor
@koikonom koikonom commented Jul 31, 2020 •
edited
Loading

Upgrade to the latest release of the terraform-plugin-sdk (v2.0.0)

Apart from updating go.mod, the import paths had to change (to add /v2), a bug was fixed, and the deprecatedImportStatePassthroughwas replaced by ImportStatePassthroughContext.

Also removed the vendor dir.

Kyriakos Oikonomakos added 4 commits July 31, 2020 13:23
remove vendor dir
395c85e
upgrade to sdkv2
aebcf23
bugfix: Add container field in group datasource schema
b8ca798
Deprecate ImportStatePassthrough
9759ac2 
Change deprecated `ImportStatePassthrough` in favour of
`ImpotStatePassthroughContext.
@koikonom koikonom requested a review from a team July 31, 2020 13:55
@alexsomesan
Copy link
Member

Fancy, very avant-garde! 🚀

But why remove the vendor dir though?
Not sure if the provider has CI stages yet, but if it does, without vendoring it will hammer GitHub to the verge of throttling when pulling modules for CI builds.

alexsomesan
alexsomesan approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member
@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Revert "remove vendor dir"
60d1db3 
This reverts commit 395c85e.
@ghost ghost added size/XL and removed size/XXL size/XXL labels Jul 31, 2020
@ghost ghost added size/XXL and removed size/XL labels Jul 31, 2020
@koikonom
Copy link
Contributor Author

You are right, I put the vendor directory back again :).

@koikonom
Copy link
Contributor Author
koikonom 8000 commented Jul 31, 2020

Closes #25

@koikonom koikonom merged commit 021b900 into master Jul 31, 2020
@koikonom koikonom deleted the sdkv2 branch July 31, 2020 14:28
@ghost ghost added size/XL and removed size/XXL size/XXL labels Jul 31, 2020
@ghost
Copy link
ghost commented Aug 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koikonom @alexsomesan
0