8000 VAULT-35602: Adding Enos OpenLDAP test by tvo0813 · Pull Request #30801 · hashicorp/vault · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

VAULT-35602: Adding Enos OpenLDAP test #30801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

VAULT-35602: Adding Enos OpenLDAP test #30801

wants to merge 31 commits into from

Conversation

tvo0813
Copy link
Collaborator
@tvo0813 tvo0813 commented May 31, 2025

Description

VAULT-35602: Adding Enos OpenLDAP test

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvo0813 tvo0813 requested a review from a team as a code owner May 31, 2025 00:09
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from 79ce381 to 2d4e10f Compare May 31, 2025 00:09
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 31, 2025
@tvo0813 tvo0813 added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.19.x backport/ent/1.18.x+ent and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels May 31, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 31, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link
github-actions bot commented May 31, 2025 •
edited
Loading

Build Results:
All builds succeeded! ✅

@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from 2d4e10f to 9ac1184 Compare June 2, 2025 22:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 2, 2025
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 5 times, most recently from b9108e4 to 10d75cb Compare June 4, 2025 00:31
brewgator
brewgator requested changes Jun 6, 2025
View reviewed changes
Copy link
Contributor
@brewgator brewgator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we write to a non-existent fake LDAP server. It might be worth updating this to point to the one Enos has spun up.

@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch 9 times, most recently from 114972c to 01fd627 Compare June 12, 2025 17:04
tvo0813 added 29 commits June 27, 2025 09:39
@tvo0813
testing leap and sles
06514dd
@tvo0813
using matrix distro
8d2de62
@tvo0813
debugging enos leap failure
c9be9da
@tvo0813
debugging enos leap failure
ba88cbf
@tvo0813
debugging enos leap failure
9ace7f6
@tvo0813
debugging enos leap failure
21d073d
@tvo0813
debugging enos leap failure
d2e8555
@tvo0813
debugging enos leap failure
04aa2d0
@tvo0813
debugging enos leap failure
ab54406
@tvo0813
testing leap and sles
24a40d7
@tvo0813
debugging enos tests
0838920
@tvo0813
debugging enos tests
81aefa3
@tvo0813
debugging enos tests
0346468
@tvo0813
debugging enos tests
875c4f1
@tvo0813
remove darwin case
84dd633
@tvo0813
changing module names to suggested names
7a649be
@tvo0813
moving depends_on for ldap server to create_vault_cluster
8143efd
@tvo0813
specifying default ldap version in modules
9499058
@tvo0813
updating LDAP_VERSION variable to LDAP_CONTAINER_VERSION
2031d03
@tvo0813
updating cidr blocks
43b99bf
@tvo0813
fixing lint
212f31a
@tvo0813
fixing lint
fc07753
@tvo0813
addressing ipv6 comments
3ab4bd0
@tvo0813
fixing lint
17f026b
@tvo0813
adding ip version
5bba1b1
@tvo0813
addressing ipv6 comments
d59cf3e
@tvo0813
fixing lint
1007d6a
@tvo0813
fixing ipv6 issue
bcc3eaa
@tvo0813 tvo0813 force-pushed the enos/VAULT-35602 branch from e3b95e4 to bcc3eaa Compare June 27, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancragun ryancragun ryancragun requested changes

@brewgator brewgator Awaiting requested review from brewgator

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/ent/1.18.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvo0813 @brewgator 32B9 @ryancragun @stevendpclark
0