8000 go mod, use/add github.com/cheggaaa/pb v1.0.27 & run go mod tidy by azr · Pull Request #154 · hashicorp/go-getter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

go mod, use/add github.com/cheggaaa/pb v1.0.27 & run go mod tidy #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2019
Merged

go mod, use/add github.com/cheggaaa/pb v1.0.27 & run go mod tidy #154

merged 2 commits into from
Jan 21, 2019

Conversation

azr
Copy link
Contributor
@azr azr commented Jan 16, 2019 •
edited
Loading

Hello, I'm new to go mod and I had the vendor locally when I did the progress bar pull request which lead to #151. I did run a few GO111MODULE=on go & GO111MODULE=on go mod commands but it added a wrong version that has a different API.

I could not find a command that would pick the correct chegaaa/pb dep for me so I manually set the version, then I ran go mod tidy, which did some magic.

Will go read about this now, I think I am missing something.

This PR closes #151

@azr azr mentioned this pull request Jan 16, 2019
Closed
@mitchellh
Copy link
Contributor

This looks good.

To get a specific revision tag you just do go get package@rev and that updates the go.mod.

In the future we might want to consider a separate go.mod for the cmd folder, but let’s not do that now. This looks good as is.

@azr
Copy link
Contributor Author
azr commented Jan 18, 2019 •
edited
Loading

Hey @mitchellh awesome, thanks, thanks for telling me this also, will use it now :)

Edit: also added a build step in travis.

@azr
Copy link
Contributor Author
azr commented Jan 21, 2019 •
edited
Loading

Merging after internal approval 🙂

@azr azr merged commit dde89f9 into master Jan 21, 2019
@azr azr deleted the add_progress_bar_dep branch January 21, 2019 17:29
@dcfsc dcfsc mentioned this pull request Jun 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot find package "github.com/cheggaaa/pb" when installing go-getter cmd
2 participants
@azr @mitchellh
0