8000 circle-ci: add tests for windows and macos & test using go 1.13 by azr · Pull Request #8078 · hashicorp/packer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

circle-ci: add tests for windows and macos & test using go 1.13 #8078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 10, 2019
Merged

circle-ci: add tests for windows and macos & test using go 1.13 #8078

merged 14 commits into from
Sep 10, 2019

Conversation

azr
Copy link
Contributor
@azr azr commented Sep 5, 2019 •
edited
Loading

this should make our testing suite a little bit better and faster

fix #8035

@azr azr requested a review from a team as a code owner September 5, 2019 13:35
@azr
Copy link
Contributor Author
azr commented Sep 5, 2019 
2019/09/05 06:37:26 Retryable error: open /Users/distiller/go/src/github.com/hashicorp/packer/common/net/packer_cache/port/1681: too many open files
--- FAIL: TestListenRangeConfig_Listen (0.51s)
panic: interface conversion: error is *os.PathError, not net.ErrPortFileLocked [recovered]
	panic: interface conversion: error is *os.PathError, not net.ErrPortFileLocked

goroutine 21 [running]:
testing.tRunner.func1(0xc000118200)
	/Users/distiller/go/src/testing/testing.go:874 +0x3a3
panic(0x18e4040, 0xc000431a10)
	/Users/distiller/go/src/runtime/panic.go:679 +0x1b2
github.com/hashicorp/packer/common/net.TestListenRangeConfig_Listen(0xc000118200)
	/Users/distiller/go/src/github.com/hashicorp/packer/common/net/configure_port_test.go:75 +0xf27
testing.tRunner(0xc000118200, 0x1a31528)
	/Users/distiller/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/Users/distiller/go/src/testing/testing.go:960 +0x350

Okay we have the #8035 issue in the darwin tests that are happening.

This is 'nice' because I can fix this using circle.

@azr azr force-pushed the circle_ci_windows branch from e62324f to 0ee0435 Compare September 5, 2019 14:26
@azr azr force-pushed the circle_ci_windows branch 2 times, most recently from 3d9770a to c804466 Compare September 5, 2019 15:08
@azr azr force-pushed the circle_ci_windows branch from c804466 to 44ba583 Compare September 5, 2019 15:11
@azr azr changed the title circle-ci: add tests for windows and macos [WIP] circle-ci: add tests for windows and macos Sep 5, 2019
@azr azr changed the title [WIP] circle-ci: add tests for windows and macos circle-ci: add tests for windows and macos Sep 5, 2019
@azr
Copy link
Contributor Author
azr commented Sep 5, 2019

Okay this is good to review; I always think I am are done when dealing with CI...

Basically we now run darwin + linux + windows tests on circle ci; I also changed the source of our fslock lib to point at mine ( github.com/azr/flock ) with a fix to that too many open files issue.

I think a file lock lib will be incorporated in a golang x/ pkg soonish. So we will remove that dep then.

@azr
Copy link
Contributor Author
azr commented Sep 5, 2019

grabbing random build times:
darwin takes ~3m50 instead of ~13m3 on travis
windows takes ~6m18 instead of 6m20 on appveyor

@azr azr force-pushed the circle_ci_windows branch from ed47849 to 986bb25 Compare September 5, 2019 16:14
@azr azr changed the title circle-ci: add tests for windows and macos circle-ci: add tests for windows and macos & test using go 1.13 Sep 10, 2019
@azr azr force-pushed the circle_ci_windows branch from f82a57d to aa9cc91 Compare September 10, 2019 10:54
@azr azr added build Relating to aspects of compilation or continuous integration enhancement labels Sep 10, 2019
@azr
Update step_shutdown_test.go
350aa54 
bump test duration
@azr
Copy link
Contributor Author
azr commented Sep 10, 2019

Okay; I'm merging this one because some other PRs need the fixes and I think it's safe enough 🙂

Let's open an issue if there's a problem !

@azr azr merged commit fbe48d4 into master Sep 10, 2019
@azr azr deleted the circle_ci_windows branch September 10, 2019 11:16
@SwampDragons SwampDragons added this to the 1.4.4 milestone Sep 13, 2019
@ghost
< 8858 path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"> Copy link
ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build Relating to aspects of compilation or continuous integration enhancement
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

TestListenRangeConfig_Listen consistently fails on Mac OSX
2 participants
@azr @SwampDragons
0