8000 Added TOC and upgraded danger-changelog to verify the keep-a-changelog formatted CHANGELOG. by dblock · Pull Request #523 · hashie/hashie · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added TOC and upgraded danger-changelog to verify the keep-a-changelog formatted CHANGELOG. #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

Added TOC and upgraded danger-changelog to verify the keep-a-changelog formatted CHANGELOG. #523

merged 1 commit into from
May 11, 2020

Conversation

dblock
Copy link
Member
@dblock dblock commented May 8, 2020 •
edited
Loading

Added TOC and upgraded danger-changelog to verify the keep-a-changelog formatted CHANGELOG. Note that the "Miscellaneous" section is not a thing in that format and that I had to fix dblock/danger-changelog#58.

@dblock dblock force-pushed the danger-toc branch 3 times, most recently from 0ecd239 to 0eb2a06 Compare May 8, 2020 20:28
@dblock dblock mentioned this pull request May 8, 2020
Open
@dblock dblock force-pushed the danger-toc branch 12 times, most recently from 6080f39 to d368a64 Compare May 8, 2020 21:51
@dblock dblock requested a review from BobbyMcWho May 8, 2020 21:55
@dblock dblock changed the title Added TOC. Added TOC and upgraded danger-changelog to verify the keep-a-changelog formatted CHANGELOG. May 8, 2020
BobbyMcWho
BobbyMcWho approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator
@BobbyMcWho BobbyMcWho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry I took a bit to get to this.

@dblock dblock merged commit 56bbb28 into hashie:master May 11, 2020
@dblock dblock deleted the danger-toc branch June 11, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

5247 @BobbyMcWho BobbyMcWho BobbyMcWho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @BobbyMcWho
0