Small amendments for Hash#merge with IndifferentAccess #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#525](https://github.com/hashie/hashie/pull/525): Small amendments for hash#merge with indifferentaccess - [@yogeshjain999](https://github.com/yogeshjain999).Generated by 🚫 Danger |
|
How did you find this? I think the first one should be testable, since if you override any of these methods in the included class merge would miss them, no? |
b025025 to
747c9cb
Compare
|
@dblock Right. How about the spec I've added ? |
1. Use `indifferent_writer` in `convert!` so that when `indifferent_writer`, `convert_key` or `indifferent_value` is overridden in included class, `merge` can use those. 2. `convert!` was calling twice if `other` hash was lacking indifference. `IndifferentAccess.inject!` already does conversion.
747c9cb to
b206fb8
Compare
|
Love the use of grumpy and indifferent cat. Merging. |
|
Now that I think about this I think there was a changelog line here, "Use |
|
Ah right 😄 |
PR it. Let's at least ack your work in CHANGELOG! |
dblock
added a commit
that referenced
this pull request
Jun 11, 2020
Small amendments for Hash#merge with IndifferentAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
indifferent_writerinconvert!so that whenindifferent_writer,convert_keyorindifferent_valueisoverridden in included class,
mergecan use those.convert!was calling twice ifotherhash was lackingindifference.
IndifferentAccess.inject!already does conversion.I've not written specs because both changes doesn't seem to be either fix or feature. But let me know if needed. 🥂