8000 Hashie::Extensions::Dash::PredefinedValues by caalberts · Pull Request #530 · hashie/hashie · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hashie::Extensions::Dash::PredefinedValues #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2020
Merged

Hashie::Extensions::Dash::PredefinedValues #530

merged 1 commit into from
Sep 24, 2020

Conversation

caalberts
Copy link
Contributor

Extends a Dash with the ability to accept only predefined values on a property.

#61

@caalberts caalberts force-pushed the dash-allowed-values branch 3 times, most recently from d9b11e1 to b465c9c Compare September 19, 2020 05:25
@caalberts
Copy link
Contributor Author

@dblock What do you think of this approach for #61 ?

@dblock
Copy link
Member
dblock commented Sep 19, 2020

I like it. Naming-wise I think we don't want to get into the business of having allow and deny lists (which can become incompatible, etc.), so I still think it should be values:. Curious what @michaelherold thinks?

dblock
dblock requested changes Sep 19, 2020
View reviewed changes
@caalberts caalberts force-pushed the dash-allowed-values branch 2 times, most recently from e9be2d6 to 4f8d65f Compare September 20, 2020 03:22
@caalberts
Add Hashie::Extensions::Dash::AllowList
4cd2844 
Extends a Dash with the ability to
accept only predefined values on a property.

hashie#61
@dblock
Copy link
Member
dblock commented Sep 22, 2020

Leaving this open for a bit to hear from other maintainers and will merge sometime by EOW otherwise.

@dblock dblock changed the title Add Hashie::Extensions::Dash::AllowList Hashie::Extensions::Dash::PredefinedValues Sep 22, 2020
@dblock
Copy link
Member
dblock commented Sep 22, 2020

Does anyone feel strongly about whether this should be called Hashie::Extensions::Dash::Values vs. Hashie::Extensions::Dash::PredefinedValues to match the keyword?

michaelherold
michaelherold approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member
@michaelherold michaelherold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 with this. I like PredefinedValues, though Enum does come to mind for me.

@dblock dblock merged commit a30327a into hashie:master Sep 24, 2020
@caalberts
Copy link
Contributor Author

Thanks @dblock @michaelherold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelherold michaelherold michaelherold approved these changes

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalberts @dblock @michaelherold
0