8000 [CI] - point to master, cover fork repos in ci, silence docker output by mur-me · Pull Request #4745 · harmony-one/harmony · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CI] - point to master, cover fork repos in ci, silence docker output #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasio 10000 nally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2024
Merged

[CI] - point to master, cover fork repos in ci, silence docker output #4745

merged 4 commits into from
Sep 5, 2024

Conversation

mur-me
Copy link
Collaborator
@mur-me mur-me commented Aug 28, 2024 •
edited
Loading

Issue

This PR includes several changes:

  1. Switch to the master branch of harmony-test repo
  2. CI Support for the forks via TRAVIS_PULL_REQUEST_SLUG.
  1. Fix for the docker logs with --progress plain,
  1. Fix for the broken GOPATH:
- echo "[WARN] - workaround for the GOPATH:"
- mv /home/travis/build/harmony-one/harmony $GOPATH/src/github.com/harmony-one/

Test

Unit Test Coverage

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    YES|NO

  2. Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.

  3. Describe how the plan was tested.

  4. How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?

  5. What are the planned flag epoch numbers and their ETAs on Pangaea?

  6. What are the planned flag epoch numbers and their ETAs on mainnet?

    Note that this must be enough to cover baking period on Pangaea.

  7. What should node operators know about this planned change?

  8. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    YES|NO

  9. Does the existing node.sh continue to work with this change?

  10. What should node operators know about this change?

  11. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

@mergify mergify bot mentioned this pull request Aug 28, 2024
Closed
@mur-me mur-me force-pushed the cover_fork_repos_in_CI branch from 2f724b7 to 98c8613 Compare August 28, 2024 13:57
@mur-me mur-me force-pushed the cover_fork_repos_in_CI branch from 98c8613 to 9b5f7f9 Compare August 30, 2024 11:11
@mur-me mur-me changed the title Cover fork repos in ci [CI] - point to master, cover fork repos in ci, silence docker output Aug 30, 2024
@mur-me mur-me merged commit 3a2349c into harmony-one:dev Sep 5, 2024
3 checks passed
@mur-me mur-me deleted the cover_fork_repos_in_CI branch September 5, 2024 11:59
@sophoah sophoah mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophoah sophoah sophoah approved these changes

@GheisMohammadi GheisMohammadi GheisMohammadi approved these changes

@Frozen Frozen Awaiting requested review from Frozen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mur-me @sophoah @GheisMohammadi
0