8000 Clear highlight when no results are found by koenpunt · Pull Request #1364 · harvesthq/chosen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clear highlight when no results are found #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in 8000 to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2013
Merged

Clear highlight when no results are found #1364

merged 1 commit into from
Jul 17, 2013

Conversation

koenpunt
Copy link
Contributor

While updating my option_adding branch I'd notice that when there are no results @result_highlight was still set and that caused problems.

Although it isn't a issue in master, I think it is incorrect to keep @result_highlight set when no results are found.

@kenearley
Copy link

Makes sense to me. :shipit:
8000

@pfiller
Copy link
Contributor
pfiller commented Jul 17, 2013

I'm on board. Thanks @koenpunt.

pfiller added a commit that referenced this pull request Jul 17, 2013
@pfiller
Merge pull request #1364 from koenpunt/no-results-clear-highlight
05c31d1 
Clear highlight when no results are found
@pfiller pfiller merged commit 05c31d1 into harvesthq:master Jul 17, 2013
pfiller added a commit that referenced this pull request Jul 17, 2013
@pfiller
Version 0.13.0
a060ce9 
- Search optgroups #1343
- Change search match style #1344
- Remove memoization of search field width. #1359
- Remove Chosen's ID dependency #1360
- Rebuild Search Results After liszt:updated #1361
- Clear highlight when no results are found #1364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koenpunt @kenearley @pfiller
0