feat: event and workflow run metadata #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-in-the-events-view
…-in-the-events-view
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 3, 2024
abelanger5
requested changes
May 6, 2024
internal/repository/event.go
Outdated
| @@ -48,6 +51,9 @@ type ListEventOpts struct { | |||
|
|
|||
| // (optional) the order direction | |||
| OrderDirection *string `validate:"omitempty, DESC"` | |||
|
|
|||
| // (optional) the event metadata | |||
| AdditionalMetadata *[]byte | |||
There was a problem hiding this comment.
Suggested change
| AdditionalMetadata *[]byte | |
| AdditionalMetadata []byte |
Arrays are nil by default, so * is unnecessary
internal/repository/workflow_run.go
Outdated
| @@ -231,6 +253,9 @@ type ListWorkflowRunsOpts struct { | |||
|
|
|||
| // (optional) the order direction | |||
| OrderDirection *string `validate:"omitempty, DESC"` | |||
|
|
|||
| // (optional) exact metadata to filter by | |||
| AdditionalMetadata *map[string]interface{} `validate:"omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| AdditionalMetadata *map[string]interface{} `validate:"omitempty"` | |
| AdditionalMetadata map[string]interface{} `validate:"omitempty"` |
internal/repository/workflow_run.go
Outdated
| @@ -248,6 +273,9 @@ type WorkflowRunsMetricsOpts struct { | |||
|
|
|||
| // (optional) the event id that triggered the workflow run | |||
| EventId *string `validate:"omitempty,uuid"` | |||
|
|
|||
| // (optional) exact metadata to filter by | |||
| AdditionalMetadata *map[string]interface{} `validate:"omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| AdditionalMetadata *map[string]interface{} `validate:"omitempty"` | |
| AdditionalMetadata map[string]interface{} `validate:"omitempty"` |
| return ec.processEvent(ctx, metadata.TenantId, payload.EventId, payload.EventKey, []byte(payload.EventData)) | ||
| additionalMetadata := make(map[string]interface{}) | ||
|
|
||
| err = json.Unmarshal([]byte(payload.EventAdditionalMetadata), &additionalMetadata) |
| @@ -0,0 +1,12 @@ | |||
| /* | |||
There was a problem hiding this comment.
Collapse into 1 migration
| @@ -17,6 +17,8 @@ import ( | |||
| ) | |||
|
|
|||
| func (t *WorkflowService) WorkflowRunCreate(ctx echo.Context, request gen.WorkflowRunCreateRequestObject) (gen.WorkflowRunCreateResponseObject, error) { | |||
| // TODO metadata | |||
steebchen
reviewed
May 6, 2024
| @@ -57,8 +59,26 @@ func (t *WorkflowService) WorkflowRunCreate(ctx echo.Context, request gen.Workfl | |||
| ), nil | |||
| } | |||
|
|
|||
| createOpts, err := repository.GetCreateWorkflowRunOptsFromManual(workflowVersion, inputBytes) | |||
| additionalMetadata := make(map[string]interface{}) | |||
There was a problem hiding this comment.
Suggested change
| additionalMetadata := make(map[string]interface{}) | |
| var additionalMetadata map[string]interface{} |
steebchen
reviewed
May 6, 2024
steebchen
reviewed
May 6, 2024
…-in-the-events-view
abelanger5
approved these changes
May 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Often arbitrary metadata tags or labels are desirable to organize events and workflow runs.
Type of change
What's Changed
References: hatchet-dev/hatchet-typescript#86