8000 fix: branch cancelation strategy by grutt · Pull Request #467 · hatchet-dev/hatchet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: branch cancelation strategy #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

grutt
Copy link
Contributor
@grutt grutt commented May 8, 2024

Description

In the event of a single step failure, it is expected and desirable for only dependent steps to be canceled down stream. In other words, independent branches can continue execution.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

What's Changed

  • revise ResolveLaterStepRuns to only update children of the current step
  • revise resolve job run query to continue in running if any running or pending step runs exist
  • fix polling for step run details based on job run statuses

@grutt grutt requested a review from abelanger5 May 8, 2024 21:14
Copy link
vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:13pm

@abelanger5 abelanger5 merged commit 93bb013 into main May 8, 2024
19 checks passed
@abelanger5 abelanger5 deleted the fix--cancelation-strategy branch May 8, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0