8000 Add indexes by mavenraven · Pull Request #478 · hatchet-dev/hatchet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add indexes #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2024
Merged

Add indexes #478

merged 3 commits into from
May 9, 2024

Conversation

mavenraven
Copy link
Contributor
@mavenraven mavenraven commented May 9, 2024 •
edited
Loading

Description

Adds discussed indexes. From this thread, I manually changed the generated sql to use CONCURRENTLY.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change (pure documentation change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking changes to code which doesn't change any behaviour)
  • CI (any automation pipeline changes)
  • Chore (changes which are not directly related to any business logic)
  • Test changes (add, refactor, improve or change a test)
  • This change requires a documentation update

What's Changed

  • Add a list of tasks or features here...

@vercel Vercel
Copy link
vercel bot commented May 9, 2024

@mavenraven is attempting to deploy a commit to the Hatchet Team on Vercel.

A member of the Team first needs to authorize it.

abelanger5
abelanger5 requested changes May 9, 2024
View reviewed changes
..._adds_index_for_resolve_workflow_run_status_and_list_job_runs_for_workflow_run/migration.sql Outdated
@@ -0,0 +1,2 @@
-- CreateIndex
CREATE INDEX CONCURRENTLY "JobRun_workflowRunId_tenantId_idx" ON "JobRun"("workflowRunId", "tenantId");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's collapse into a single migration - migrations should correspond to releases, so v0.26.0 would work for this. You can do this manually as well by copying them all into a migration folder called 20240509163031_v0_26_0 or something.

@mavenraven mavenraven requested a review from abelanger5 May 9, 2024 20:41
@abelanger5 abelanger5 merged commit ac36464 into hatchet-dev:main May 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelanger5 abelanger5 abelanger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavenraven @abelanger5
0