feat: variable token expiration #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
commented
Jun 28, 2024
| type: string | ||
| description: The duration for which the token is valid. | ||
| x-oapi-codegen-extra-tags: | ||
| validate: "omitnil,duration" |
There was a problem hiding this comment.
I may be losing my mind, but this validator seems to not accept the things it says it accepts. It will not accept y or M for example.
DurationErr = "Invalid duration. Durations must be in the format <number><unit>, where unit is one of: 's', 'm', 'h', 'd', 'w', 'M', 'y'"
I thought we already addressed this but I can't find the PR.
steebchen
requested changes
Jun 28, 2024
frontend/app/src/pages/main/tenant-settings/api-tokens/components/create-token-dialog.tsx
Show resolved
Hide resolved
steebchen
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3 month expiration was cumbersome for some folks, this PR makes the expiration duration configurable for tokens created with the CLI and the Dashboard
Type of change
What's Changed
expiresInoption on the create token api