10000 Fix: python sdk docs hatchet.admin references by wcbzero · Pull Request #678 · hatchet-dev/hatchet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: python sdk docs hatchet.admin references #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix: python sdk docs hatchet.admin references #678

merged 1 commit into from
Jul 1, 2024

Conversation

wcbzero
Copy link
Contributor
@wcbzero wcbzero commented Jul 1, 2024

Fix references to hatchet admin module in python-sdk docs

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change (pure documentation change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking changes to code which doesn't change any behaviour)
  • CI (any automation pipeline changes)
  • Chore (changes which are not directly related to any business logic)
  • Test changes (add, refactor, improve or change a test)
  • This change requires a documentation update

What's Changed

  • Add a list of tasks or features here...

@wcbzero
Fix: python sdk docs hatchet.admin references
0148736 
Fix references to hatchet admin module in python-sdk docs
@vercel Vercel
Copy link
vercel bot commented Jul 1, 2024

@wcbzero is attempting to deploy a commit to the Hatchet Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link
vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 6:15pm

abelanger5
abelanger5 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor
@abelanger5 abelanger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wcbzero, thanks for the PR!

Looks like the discrepancy is due to the usage of new_client vs the Hatchet class instance. In the case of using hatchet = Hatchet(), hatchet.client is necessary. In the case of hatchet = new_client(), hatchet represents the client instance. We'll make sure to remove examples of new_client.

@abelanger5 abelanger5 merged commit 49709e8 into hatchet-dev:main Jul 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelanger5 abelanger5 abelanger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcbzero @abelanger5
0