Fix: Move Non-Retryable to hatchet_sdk.exceptions
#1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves the NonRetryableException from hatchet_sdk.runnables.task to hatchet_sdk.exceptions to improve modularity while also delaying the instantiation of ClientConfig to prevent config loading errors.
- Updated pyproject.toml version to 1.2.2
- Adjusted imports in runner.py, init.py, and examples to reference hatchet_sdk.exceptions for NonRetryableException
- Modified Hatchet.init to allow an optional config parameter and instantiate ClientConfig only when needed
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdks/python/pyproject.toml | Version bump to reflect change updates |
| sdks/python/hatchet_sdk/worker/runner/runner.py | Updated import for NonRetryableException |
| sdks/python/hatchet_sdk/runnables/task.py | Removed NonRetryableException definition now located in exceptions |
| sdks/python/hatchet_sdk/hatchet.py | Changed default config handling to prevent early config loading errors |
| sdks/python/hatchet_sdk/exceptions.py | Added NonRetryableException definition |
| sdks/python/hatchet_sdk/init.py | Removed export of NonRetryableException from this module |
| sdks/python/examples/non_retryable/worker.py | Updated import to reference hatchet_sdk.exceptions for NonRetryableException |
grutt
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the
NonRetryableExceptiontohatchet_sdk.exceptionsand not having a defaultClientConfigat import time to prevent config loading errorsAlso removed some deps we're not using