fix: filter scope for bulk ops #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
sdks/typescript/src/v1/examples/cancellations/run.ts:9
- [nitpick] The variable name 'run1' may be unclear; consider using a more descriptive name if it represents a distinct cancellation instance.
const run1 = cancellation.runNoWait({});
internal/services/admin/v1/server.go:59
- [nitpick] Consider removing the debug log statement or replacing it with a proper logging mechanism to avoid accidental production output.
fmt.Println("workflowIds", workflowIds)
internal/services/admin/v1/server.go:170
- [nitpick] Since similar filtering logic now appears in both CancelTasks and ReplayTasks, consider refactoring it into a shared helper to reduce duplication and potential inconsistencies.
if req.Filter != nil {
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- sdks/typescript/package.json: Language not supported
Comments suppressed due to low confidence (2)
sdks/typescript/src/v1/examples/cancellations/run.ts:9
- [nitpick] Consider using a more descriptive variable name instead of 'run1' to clarify its distinct role in the example.
const run1 = cancellation.runNoWait({});
sdks/typescript/src/v1/client/features/runs.ts:95
- If opts.ids is provided as an empty array, the filter will be omitted even though no external ids are effectively given; consider explicitly checking for undefined instead of falsy values.
filter: !opts.ids ? filter : undefined,
mrkaye97
approved these changes
Apr 7, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@hatchet-dev/typescript-sdk", | |||
| "version": "1.1.3", | |||
| "version": "1.1.5", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes scopes similar to #1502