fix: namespace #1549
Merged
fix: namespace #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| // FIXME: the config loader is called twice so we get a double _ | ||
| if (this.config.namespace) { | ||
| this.config.namespace = this.config.namespace.replace('__', '_'); |
There was a problem hiding this comment.
Consider using a global replacement if there's a possibility of multiple double underscores in the namespace, e.g. using a regular expression like this.config.namespace.replace(/__+/g, '_').
Suggested change
| this.config.namespace = this.config.namespace.replace('__', '_'); | |
| this.config.namespace = this.config.namespace.replace(/__+/g, '_'); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
what happens if someone makes their namespace matt__dev or something?
There was a problem hiding this comment.
that's fair, let me move this up to the new client and remove the trailing underscore there
grutt
commented
Apr 14, 2025
| @@ -89,6 +89,12 @@ export class HatchetClient implements IHatchetClient { | |||
| logger: logConstructor, | |||
| }; | |||
|
|
|||
| if (clientConfig.namespace) { | |||
| clientConfig.namespace = clientConfig.namespace.endsWith('_') | |||
There was a problem hiding this comment.
@mrkaye97 this should be safer
mrkaye97
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nested client adds a _
Type of change