8000 refactor: cleanup functions in api + worker by steebchen · Pull Request #192 · hatchet-dev/hatchet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: cleanup functions in api + worker #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 1, 2024
Merged

refactor: cleanup functions in api + worker #192

merged 7 commits into from
Mar 1, 2024

Conversation

steebchen
Copy link
Collaborator
@steebchen steebchen commented Feb 24, 2024 •
edited
Loading

Description

Adds cleanup functions to the API and the worker instance instead of cancelling via context

Type of change

  • Refactor

What's Changed

  • cleanup functions in worker
  • proper cleanup in api
  • refactor api

@vercel Vercel
Copy link
vercel bot commented Feb 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 11:10am

@steebchen steebchen force-pushed the refactor/api-cleanup branch from c2a3993 to 0c0ba11 Compare February 24, 2024 15:43
@steebchen steebchen force-pushed the refactor/api-cleanup branch from 0c0ba11 to a7fe490 Compare February 24, 2024 16:05
@steebchen steebchen force-pushed the refactor/api-cleanup branch from a7fe490 to ceba876 Compare February 26, 2024 06:11
@steebchen steebchen marked this pull request as draft February 27, 2024 17:14
@steebchen steebchen force-pushed the refactor/api-cleanup branch from ceba876 to af676de Compare February 27, 2024 18:25
@steebchen steebchen force-pushed the refactor/api-cleanup branch from af676de to 336d1e8 Compare February 29, 2024 16:59
@steebchen steebchen changed the title refactor(api): add cleanup functions refactor(api): cleanup functions in api + worker Feb 29, 2024
@steebchen steebchen changed the title refactor(api): cleanup functions in api + worker refactor: cleanup functions in api + worker Feb 29, 2024
@steebchen steebchen marked this pull request as ready for review February 29, 2024 18:12
@steebchen steebchen requested a review from abelanger5 February 29, 2024 18:12
@steebchen steebchen force-pushed the refactor/api-cleanup branch from f4ba8df to ab7f2ac Compare March 1, 2024 10:32
steebchen
steebchen commented Mar 1, 2024
View reviewed changes
steebchen
steebchen commented Mar 1, 2024
View reviewed changes
steebchen
steebchen commented Mar 1, 2024
View reviewed changes
@steebchen steebchen force-pushed the refactor/api-cleanup branch from 91f0118 to ab7f2ac Compare March 1, 2024 11:08
@steebchen steebchen linked an issue Mar 1, 2024 that may be closed by this pull request
graceful shutdown of worker and hatchet-api #190
Closed
abelanger5
abelanger5 approved these changes Mar 1, 2024
View reviewed changes
@steebchen steebchen merged commit 9b68115 into main Mar 1, 2024
@steebchen steebchen deleted the refactor/api-cleanup branch March 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelanger5 abelanger5 abelanger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graceful shutdown of worker and hatchet-api
2 participants
@steebchen @abelanger5
0