chore: add better telemetry to database #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steebchen
approved these changes
Mar 15, 2024
Comment on lines
+400
to
+404
| ctx, span1 := telemetry.NewSpan(ctx, "db-list-workflows-for-event") | ||
| defer span1.End() | ||
|
|
||
| tx, err := r.pool.Begin(context.Background()) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| defer deferRollback(context.Background(), r.l, tx.Rollback) | ||
| ctx, span2 := telemetry.NewSpan(ctx, "db-list-workflows-for-event-query") | ||
| defer span2.End() |
There was a problem hiding this comment.
Isn't this just a duplicate now?
There was a problem hiding this comment.
Nice catch, I added another span2.End later on as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
otelpgxintegration to the database for better observability around queries.Type of change
What's Changed
otelpgx